[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360152: [OpenCL] Prevent mangling kernel functions. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60454?vs=197934=198467#toc

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60454/new/ https://reviews.llvm.org/D60454 ___ cfe-commits mailing list

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

Anastasia added a comment. In D60454#1488348 , @rjmccall wrote: > I think it would be more reasonable to just change `getDeclLanguageLinkage` > to check for a kernel function. I tried to change `getDeclLanguageLinkage` only but Sema calls

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

Anastasia updated this revision to Diff 197934. Anastasia marked an inline comment as done. Anastasia added a comment. Removed redundant C linkage checks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60454/new/ https://reviews.llvm.org/D60454 Files:

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

rjmccall added a comment. I think it would be more reasonable to just change `getDeclLanguageLinkage` to check for a kernel function. Comment at: lib/AST/Decl.cpp:2940 + if (hasAttr()) +return true; return isDeclExternC(*this); Both of these changes

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

Anastasia updated this revision to Diff 197791. Anastasia added a comment. Extended `FunctionDecl` exten C logic to take kernel function into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60454/new/ https://reviews.llvm.org/D60454 Files:

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

rjmccall added a comment. I think it would be more reasonable to just change `getDeclLanguageLinkage` to check for a kernel function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60454/new/ https://reviews.llvm.org/D60454 ___ cfe-commits

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

Anastasia created this revision. Anastasia added reviewers: rjmccall, bader. Herald added subscribers: ebevhan, yaxunl. Kernel function names have to be preserved as in the original source to be able to access them from the host API side. This patch adds restriction to kernels that prevents