[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

This revision was automatically updated to reflect the committed changes. Closed by commit rGc094e7dc4b3f: [SYCL] Add sycl_kernel attribute for accelerated code outlining (authored by Fznamznon, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231679. bader marked 2 inline comments as done. bader added a comment. Fixed SYCL code example for sycl_kernel attribute documentation and commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader added a comment. I hope all comments from are @Fznamznon and @aaron.ballman are applied. @ABataev, do you have any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

aaron.ballman added inline comments. Comment at: clang/test/SemaSYCL/kernel-attribute.cpp:4-5 + +__attribute((sycl_kernel)) void foo() { +} bader wrote: > aaron.ballman wrote: > > aaron.ballman wrote: > > > Missing some tests: > > > * test that both attributes

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Fznamznon accepted this revision. Fznamznon added a comment. LGTM with a couple of minor comments. Comment at: clang/include/clang/Basic/AttrDocs.td:273 +cgh.parallel_for(range<1>{1024}, [=](id<1> index) { + A[index] = index[0] * 2 + index[1] + foo(42); +});

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231644. bader marked an inline comment as done. bader added a comment. Applied @aaron.ballman suggestions to kernel-attribute.cpp test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader marked 5 inline comments as done. bader added inline comments. Comment at: clang/test/SemaSYCL/kernel-attribute.cpp:4-5 + +__attribute((sycl_kernel)) void foo() { +} aaron.ballman wrote: > aaron.ballman wrote: > > Missing some tests: > > * test that both

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with some testing requests. Comment at: clang/test/SemaSYCL/kernel-attribute.cpp:4-5 + +__attribute((sycl_kernel)) void foo() { +} aaron.ballman wrote: > Missing some tests: > * test

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231595. bader marked 4 inline comments as done. bader added a comment. Applied comments from @Fznamznon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files:

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Fznamznon added a comment. A couple of minor comments. Comment at: clang/include/clang/Basic/AttrDocs.td:313 + +- Function template with at least two template parameters is expected. The compiler +generates OpenCL kernel and uses first template parameter as unique name to the

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231506. bader added a comment. Minor update adjusting to the recent changes. Updated comment "The 'sycl_kernel' attribute applies only to functions" -> "The 'sycl_kernel' attribute applies only to function templates". Renamed tests from "device-attributes*"

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader added a comment. In D60455#1762804 , @Anastasia wrote: > Sorry, I don't have capacity currently to review this and I don't want to be > blocking it either. @Anastasia, thanks for finding time for reviewing previous revisions of the patch. I

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

Anastasia resigned from this revision. Anastasia added a comment. This revision is now accepted and ready to land. Sorry, I don't have capacity currently to review this and I don't want to be blocking it either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231396. bader added a comment. Fixed typo in the commit message: complier -> compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: