[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

sammccall added a comment. In D60539#1469012 , @nemanjai wrote: > > Do you need to build clangd? We explicitly don't aim to support building > > everywhere clang can be built, maybe we should just disable in this case? > > Our environment includes

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

nemanjai added a comment. > Do you need to build clangd? We explicitly don't aim to support building > everywhere clang can be built, maybe we should just disable in this case? Our environment includes various OS levels running on PowerPC. We certainly wouldn't want to disable building/testing

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

rsmith added a comment. In D60539#1464097 , @sammccall wrote: > Adding `-std=c++14` doesn't work in general as it has side-effects: `clang > -std=c++14 foo.c` is a warning, `clang -std=c++14 -x c-header foo.h` is an > error. It would be nice if clang

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Herald added a subscriber: jsji. I don't think this is a suitable fix :-( There are lots of places where we construct command-lines in tests, it may be true today that this is

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Generally it's a good thing for our test suite to be robust against changes to Clang's default language mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60539/new/

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

amyk created this revision. amyk added reviewers: ilya-biryukov, sammccall, ioeric, hokein, akyrtzi, yvvan. amyk added projects: clang, LLVM. Herald added subscribers: kadircet, arphaman, dexonsmith, jkorous. On one of the platforms that we build on, we build with the CMake macro,