[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

This revision was automatically updated to reflect the committed changes. Closed by commit rC358882: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG… (authored by brunoricci, committed by ). Changed prior to commit:

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno added a comment. In D60573#1463777 , @rjmccall wrote: > In D60573#1463641 , @riccibruno > wrote: > > > In D60573#1463569 , @rjmccall > > wrote: > > > > > Hmm.

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rjmccall added a comment. In D60573#1463641 , @riccibruno wrote: > In D60573#1463569 , @rjmccall wrote: > > > Hmm. Does this never impact code that's just using a locally-defined type > > within its scope? I

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno added a comment. In D60573#1463611 , @rsmith wrote: > > I have applied the fix to all language versions, even though I think that > > the DR only applies to C++14 > > DRs don't have a specific version that they are intended to apply to; that's

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno added a comment. In D60573#1463569 , @rjmccall wrote: > Hmm. Does this never impact code that's just using a locally-defined type > within its scope? I guess if ADL is involved, unqualified lookup must have > reached the scope of the

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rsmith accepted this revision. rsmith added a comment. > I have applied the fix to all language versions, even though I think that the > DR only applies to C++14 DRs don't have a specific version that they are intended to apply to; that's up to us to determine, and generally we apply them

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Hmm. Does this never impact code that's just using a locally-defined type within its scope? I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno updated this revision to Diff 194765. riccibruno added a comment. Removed the call to `isTransparentContext()` in the loop in `CollectEnclosingNamespace`. It is not actually needed since we only care about finding the innermost enclosing namespace. Repository: rC Clang CHANGES

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno created this revision. riccibruno added reviewers: rjmccall, Quuxplusone. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a parent revision: D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup. CWG 1691 changed