[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

2019-04-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D60822#1470227 , @kadircet wrote: > I agree that these are more useful. What about also adding "-W" in front of > warning flags to make them more explicit and stand out from "non-flag" error > names? I went back and forth

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

2019-04-17 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358611: [clangd] Use shorter, more recognizable codes for diagnostics. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D60822?vs=195623=195624#toc

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

2019-04-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 195623. sammccall added a comment. -Wfoo instead of foo Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60822/new/ https://reviews.llvm.org/D60822 Files: clangd/Diagnostics.cpp

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

2019-04-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. I agree that these are more useful. What about also adding "-W" in front of warning flags to make them more explicit and stand out from "non-flag" error names? Repository: rCTE Clang

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

2019-04-17 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. - for warnings, use "foo" if the warning is controlled by -Wfoo - for errors, keep using the internal