[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

This revision was automatically updated to reflect the committed changes. Closed by commit rL358674: [Serialization] Stable serialization order for OpenCLTypeExtMap and… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. >> We could still go for something like the following but accept that some a >> random failure might happen not necessarily on a commit that introduces it? > > I am not sure that this

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

riccibruno added a comment. In D60835#1471498 , @Anastasia wrote: > In D60835#1470805 , @riccibruno > wrote: > > > By the way, I am wondering about how much this is tested. I did look > > quickly in `test/PCH`

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

Anastasia added a comment. In D60835#1470805 , @riccibruno wrote: > By the way, I am wondering about how much this is tested. I did look quickly > in `test/PCH` and it appears that there are only 3 (short) tests : > `ocl_types.cl`,

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

riccibruno added a comment. By the way, I am wondering about how much this is tested. I did look quickly in `test/PCH` and it appears that there are only 3 (short) tests : `ocl_types.cl`, `opencl-extensions.cl` and `no-validate-pch`. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

riccibruno created this revision. riccibruno added reviewers: Anastasia, lebedev.ri. riccibruno added a project: clang. Herald added subscribers: cfe-commits, mgrang, yaxunl. Sort the elements of `Sema::OpenCLTypeExtMap` and `Sema::OpenCLDeclExtMap` by `TypeID`s and `DeclID`s to guarantee a