[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-30 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In Swift we basically shove *everything* through our corresponding linkage-entity structure, so I'm not opposed to the basic idea. That said, it's unfortunate that this needs to be raised to the AST level. Also, you have really been contributing to this project far to

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-24 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359148: [codeview] Fix symbol names for dynamic initializers and atexit stubs (authored by rnk, committed by ). Changed p

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-24 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D60930#1474460 , @jyu2 wrote: > Looks good to me. We are basically de-mangled name for those __E initialize > global’s function and __F destroy global's function. Thanks! I'm going to land this, but @rjmccall, let me know if

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-22 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. Looks good to me. We are basically de-mangled name for those __E initialize global’s function and __F destroy global's function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60930/new/ https://reviews.llvm.org/D60930 _

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: rsmith, rjmccall, jyu2. Herald added a subscriber: aprantl. Herald added a project: clang. Add a new variant to GlobalDecl for these so that we can detect them more easily during debug info emission and handle them appropriately. Repository: rG L