This revision was automatically updated to reflect the committed changes.
Closed by commit rL359075: [clang][HeaderSearch] Make sure there are no
backslashes in suggestedPath (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
kadircet updated this revision to Diff 196393.
kadircet added a comment.
- Update comments to focus on forward slashes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
https://reviews.llvm.org/D60995
Files:
sammccall added inline comments.
Comment at: clang/include/clang/Lex/HeaderSearch.h:710
+ /// Suggest a path by which the specified file could be found, for use in
+ /// diagnostics to suggest a #include. Returned path will be valid for
+ /// include-directive.
kadircet updated this revision to Diff 196392.
kadircet added a comment.
- Update documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
https://reviews.llvm.org/D60995
Files:
clang/include/clang/Lex/HeaderSearch.h
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Can you document this in `HeaderSearch.h`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
kadircet updated this revision to Diff 196192.
kadircet added a comment.
- Fix bug in HeaderSearch instead of clangd
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60995/new/
https://reviews.llvm.org/D60995
Files:
clang/lib/Lex/HeaderSearch.cpp
