This revision was automatically updated to reflect the committed changes.
Closed by commit rC359360: [Fuchsia] Support multilib for -fsanitize=address
and -fno-exceptions (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61040?vs=196791=196934#toc
phosek updated this revision to Diff 196791.
phosek marked 2 inline comments as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61040/new/
https://reviews.llvm.org/D61040
Files:
clang/lib/Driver/ToolChains/CommonArgs.cpp
mcgrathr added inline comments.
Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:179
+ .flag("+fno-exceptions");
+ Multilib ASan = Multilib("/asan", "", "", 2).flag("+fsanitize=address");
+ Multilibs.push_back(Default);
Add a
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1507
+Multilib::flags_list ) {
+ if (Enabled)
+
On Tue, Apr 23, 2019 at 11:36 PM Petr Hosek via Phabricator <
revi...@reviews.llvm.org> wrote:
> phosek added inline comments.
>
>
>
> Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122
> +
> +/// \p Flag must be a flag accepted by the driver with its leading '-'
> removed,
phosek added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122
+
+/// \p Flag must be a flag accepted by the driver with its leading '-' removed,
+// otherwise '-print-multi-lib' will not emit them correctly.
jroelofs wrote:
> Can we
jroelofs added inline comments.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122
+
+/// \p Flag must be a flag accepted by the driver with its leading '-' removed,
+// otherwise '-print-multi-lib' will not emit them correctly.
Can we enforce this
phosek created this revision.
phosek added reviewers: beanz, jroelofs, mcgrathr.
Herald added subscribers: cfe-commits, javed.absar.
Herald added a project: clang.
This introduces a support for multilibs to Fuchsia driver. Unlike the
existing multilibs that are used primarily for handling
