jkorous abandoned this revision.
jkorous added a comment.
Abandoned in favor of https://reviews.llvm.org/D65301
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61103/new/
https://reviews.llvm.org/D61103
___
cfe-commits mailing list
cfe-commit
gribozavr added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:584
+// terminating early.
+for (auto CIt = RawComments.begin(); CIt != RawComments.end(); ++CIt) {
+ RawComment *C = *CIt;
jkorous wrote:
> gribozavr wrote:
> > Scanning all c
gribozavr added a comment.
> Also, IIUC the test case that I deleted wasn't actually supposed to produce
> any diagnostics and the fact that it did was a bug. We could keep it as a
> regression test but I think it has a rather low value. WDYT?
What do you mean? The issue that the test is tryin
jkorous added a comment.
Also, IIUC the test case that I deleted wasn't actually supposed to produce any
diagnostics and the fact that it did was a bug. We could keep it as a
regression test but I think it has a rather low value. WDYT?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6110
jkorous updated this revision to Diff 196744.
jkorous added a comment.
- clang-format
- comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61103/new/
https://reviews.llvm.org/D61103
Files:
clang/include/clang/AST/ASTContext.h
clang/lib/AST/ASTContext.cpp
clang/lib/Sema/SemaDe
jkorous marked 5 inline comments as done.
jkorous added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:494
+ // Explicitly not calling ExternalSource->ReadComments() as we're not
+ // interested in those.
+ ArrayRef RawComments = Comments.getComments();
gribozavr added a comment.
> The FIXME in tests is fixed now.
... so instead of deleting the test, could you change it to show the current,
better diagnostic?
Comment at: clang/include/clang/AST/ASTContext.h:818
+ /// For every comment not attached to any decl check if it sh
jkorous created this revision.
jkorous added reviewers: gribozavr, arphaman.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.
Loading external comments and sorting them is expensive - mostly due to
getDecomposedLoc() begin expensive. For modules with very large nu
