This revision was automatically updated to reflect the committed changes.
Closed by commit rL359654: lib/Header: Fix Visual Studio builds try #2
(authored by tstellar, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
smeenai accepted this revision.
smeenai added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61220/new/
https://reviews.llvm.org/D61220
___
cfe-commits mailing list
tstellar updated this revision to Diff 197244.
tstellar marked an inline comment as done.
tstellar added a comment.
Make sure to install the generated files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61220/new/
https://reviews.llvm.org/D61220
vzakhari added a comment.
OK, this should work while clang_generate_header() is used for plain files.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61220/new/
https://reviews.llvm.org/D61220
___
tstellar updated this revision to Diff 197233.
tstellar added a comment.
- Fix install directory
- Use a separate install targets for each sub-directory like it was done before
r355253.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61220/new/
vzakhari added inline comments.
Comment at: clang/lib/Headers/CMakeLists.txt:176
install(
- DIRECTORY ${output_dir}
+ FILES ${install_files}
DESTINATION ${header_install_dir}
vzakhari wrote:
> This is going to flatten the headers' install directory
vzakhari added inline comments.
Comment at: clang/lib/Headers/CMakeLists.txt:173
set(header_install_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION})
Please add "/include" at the end.
Comment at: clang/lib/Headers/CMakeLists.txt:176
tstellar created this revision.
tstellar added reviewers: smeenai, vzakhari, phosek.
Herald added a subscriber: mgorny.
Herald added a project: clang.
This is a follow up to r355253 and a better fix than the first attempt
which was r359257.
We can't install anything from ${CMAKE_CFG_INTDIR},
