[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360214: [hip] Fix ambiguity from `` of CUDA. (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao marked an inline comment as done. hliao added a comment. done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao updated this revision to Diff 198545. hliao added a comment. Add one unrealistic case for test purpose only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 Files:

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParseTentative.cpp:597 NextToken().isOneOf(tok::greater, tok::greatergreater, +

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao marked an inline comment as done. hliao added a comment. done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao updated this revision to Diff 198529. hliao added a comment. revise following reviewer's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 Files: clang/lib/Parse/ParseTentative.cpp

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:597 + tok::comma || +(getLangOpts().CUDA && Tok.is(tok::greatergreatergreater { TPR = TPResult::True; No need to

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. @rsmith Do you have the chance to review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. @rsmith Do you have the chance to review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. @rsmith do you have the chance to review this simple fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

yaxunl added a comment. LGTM too. Thanks Michael for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. In D61396#1486706 , @tra wrote: > LGTM, but I've added @rsmith who is way more familiar with this code. sure, no rush, let's wait for comments from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

tra added a comment. LGTM, but I've added @rsmith who is way more familiar with this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - For template arguments ending with `>>>`, we should cease lookahead and treat it as type-id firstly, so that deduction could work properly. Repository: rG