[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nah, it's ok. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. (doh, sorry - I thought this was accepted. Happy to revert, or try the lexer soon if you think it's important. Case-sensitive matching was still slightly negative within the noise) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360030: [clangd] Boost code completion results that were named in the last few lines. (authored by sammccall, committed

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. In D61537#1491649 , @ilya-biryukov wrote: > Nice! Looking at the numbers, the improvements look worthwhile. > > The stopwords don't seem to be in the patch anymore, but they do seem like a > good idea. Specifically, we might

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198243. sammccall marked 3 inline comments as done. sammccall added a comment. Comment about keywords Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files:

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198242. sammccall added a comment. address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/CodeComplete.cpp clangd/FindSymbols.cpp

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nice! Looking at the numbers, the improvements look worthwhile. The stopwords don't seem to be in the patch anymore, but they do seem like a good idea. Specifically, we might want to remove all keywords - the intuition is that they don't provide much value,

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198178. sammccall added a comment. Further tune numbers based on experiments. Remove stopwords due to new threshold. Fix tests. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198129. sammccall added a comment. Tune magic numbers Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/CodeComplete.cpp clangd/FindSymbols.cpp

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall created this revision. Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The hope is this will catch a few patterns with repetition: SomeClass* S = ^SomeClass::Create() int getFrobnicator() { return