This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE361344: [clang-tidy] remove default header-filter for
run-clang-tidy (authored by dhinton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61747?vs=198877=200620#toc
Repository:
hintonda accepted this revision.
hintonda added a comment.
This revision is now accepted and ready to land.
LGTM. If no further comments, I'll commit it for you tomorrow.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61747/new/
hintonda added a comment.
After thinking about it, I agree with this change -- there's no way to provide
an appropriate default at this level.
So, LGTM, but wait for @alexfh's okay.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61747/new/
hintonda added a comment.
I've also had issues with this behavior. It's a bad default, as the PR notes,
but is there a way to provide a better one and still respect the config file?
Also, could you add a test for this? Perhaps in
`clang-tools-extra/test//clang-tidy/run-clang-tidy.cpp`.
torbjoernk created this revision.
torbjoernk added reviewers: alexfh, bkramer.
torbjoernk added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a project: clang.
run-clang-tidy.py was enforcing '-header-filter' parameter with an
unfortunate default
