[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. In D61912#1521476 , @Szelethus wrote: > I think cfe-commits is added automatically if you add "Clang" to the > "Repository" field when creating a new Differential. Exactly, thanks! Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D61912#1521411 , @Charusso wrote: > >> In D61912#1521306 , @lebedev.ri > >> wrote: > >> > >>> All these patches bypassed cfe-commits. > >> > >> > >> Bypassed? It is only added when

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. >> In D61912#1521306 , @lebedev.ri >> wrote: >> >>> All these patches bypassed cfe-commits. >> >> >> Bypassed? It is only added when you push your stuff, which is happened as >> expected. > > That is pretty much the opposite

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D61912#1521352 , @Charusso wrote: > Hey @lebedev.ri, thanks for the review! > > In D61912#1521306 , @lebedev.ri > wrote: > > > All these patches bypassed cfe-commits. > > > Bypassed?

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. Hey @lebedev.ri, thanks for the review! In D61912#1521306 , @lebedev.ri wrote: > All these patches bypassed cfe-commits. Bypassed? It is only added when you push your stuff, which is happened as expected. > Why does this inve

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. All these patches bypassed cfe-commits. Why does this invent a yet another json formatter instead of using `"llvm/Support/JSON.h"`, in particular it's lightweight `json::OStream` ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61912/ne

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

2019-05-29 Thread Csaba Dabis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC361972: [analyzer] print() JSONify: Store implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D61912?vs=201564