[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

This revision was automatically updated to reflect the committed changes. Closed by commit rL361516: [WebAssembly] Add multivalue and tail-call target features (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D62047?vs=199941=201010#toc Repository: rL

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin added a comment. I see. LGTM either way  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62047/new/ https://reviews.llvm.org/D62047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

tlively added a comment. In D62047#1505878 , @aheejin wrote: > How about using `multi_value`/`multi-value`/`MultiValue`/`MULTI-VALUE` > (depending on positions)? The repo name is also multi-value. > https://github.com/WebAssembly/multi-value >

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin added a comment. In D62047#1505838 , @sbc100 wrote: > Does it make sense to support the flags before we support the feature? > > Otherwise lgtm. I think this is OK; flags anyway should be added before actual feature implementation starts in

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. How about using `multi-value`/`MultiValue`/`MULTI-VALUE` (depending on positions)? The repo name is also multi-value. https://github.com/WebAssembly/multi-value Otherwise LGTM.

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

sbc100 added a comment. Does it make sense to support the flags before we support the feature? Otherwise lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62047/new/ https://reviews.llvm.org/D62047

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. These features will both be implemented soon, so I thought I would save time by adding