[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added a comment. In D62050#1509400 , @vitalybuka wrote: > In D62050#1509384 , @vitalybuka > wrote: > > > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake > > in empty directory)

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. In D62050#1509384 , @vitalybuka wrote: > This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in > empty directory) I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right appro

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

vitalybuka added a comment. This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory) http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21622/steps/check-cfi-and-supported%20in%20gcc%20build/logs/stdio 100%] Running the cfi regression tests

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() hintonda wrote: > This is a breaking patch. What's the rational for u

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

hintonda added inline comments. Comment at: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake:930 -else() +if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB) set(LLVM_ENABLE_PLUGINS ON) endif() This is a breaking patch. What's the rational for unilaterally disabl

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rL360991: [Analysis] Only run plugins tests if plugins are actually enabled (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62050?vs=199955&id=199977#toc Repositor

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Thank you so much! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62050/new/ https://reviews.llvm.org/D62050

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

phosek created this revision. phosek added reviewers: smeenai, Szelethus, NoQ. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. When plugins aren't enabled, don't try to run plugins tests. Don't enable plugins unconditionally based on the platform, i