[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

2020-05-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Heh, @RKSimon and I were going through fixing up warnings noted in that blog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62230/new/ https://reviews.llvm.org/D62230

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

2020-05-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Looks like this may've already been addressed in cfee2efc57b27ce7eed932528e219a99f934d3ca ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62230/new/ https://reviews.llvm.org/D62230

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

2019-05-21 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Also of note is that no existing test covers this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62230/new/ https://reviews.llvm.org/D62230 ___ cfe-commits

[PATCH] D62230: [CGDebugInfo] return early on failed dyn_cast

2019-05-21 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. Also of note is that no existing test covers this case. This was flagged in https://www.viva64.com/en/b/0629/