[PATCH] D62279: Use LTO capable linker

This revision was automatically updated to reflect the committed changes. Closed by commit rL362624: Use LTO capable linker (authored by cbieneman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62279: Use LTO capable linker

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This is good to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62279/new/ https://reviews.llvm.org/D62279

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. So this compiles and as such improves on what we currently have and as such I think it should be merged, although there maybe other solutions. It still fails `ninja stage2-check-all` with the gtest problem which @beanz is working on resolving. Repository: rG

[PATCH] D62279: Use LTO capable linker

winksaville updated this revision to Diff 201288. winksaville added a comment. Added libcxxabi and rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62279/new/ https://reviews.llvm.org/D62279 Files:

Re: [PATCH] D62279: Use LTO capable linker

> On May 23, 2019, at 2:40 PM, Wink Saville via Phabricator > wrote: > > winksaville added a comment. > > In D62279#1514596 , @beanz wrote: > >> @winksaville I've figured out how to resolve the `gtest` issue, but >> unfortunately that isn't good

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. In D62279#1514596 , @beanz wrote: > @winksaville I've figured out how to resolve the `gtest` issue, but > unfortunately that isn't good enough to get the `check-runtimes` target > working. A change went in back in February

[PATCH] D62279: Use LTO capable linker

beanz added a comment. @winksaville I've figured out how to resolve the `gtest` issue, but unfortunately that isn't good enough to get the `check-runtimes` target working. A change went in back in February (rL353601 ), which breaks running compiler-rt's tests

[PATCH] D62279: Use LTO capable linker

beanz added a comment. In D62279#1514467 , @winksaville wrote: > Even with both gtest patches it still isn't working, `ninja check-all` is > failing as before :( I wouldn't expect your gtest patch to resolve the issue. The `CLANG_BOOTSTRAP_TARGETS`

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. > Are you still having that issue after rL361436 > ? That should have resolved that problem. > The issue isn't that gtest is missing from the bootstrap, but rather that it > was missing from the dependencies for the runtime

[PATCH] D62279: Use LTO capable linker

beanz added a comment. In D62279#1514046 , @winksaville wrote: > I've add gtest_main and gtest to CLANG_BOOTSTRAP_TARGETS as a guess, because > that's where check-all is defined: > ... > My guess is likely wrong, what do you advise? Are you still

[PATCH] D62279: Use LTO capable linker

winksaville added a comment. Adding libcxxabi worked and `ninja stage2-distribution` succeeded but I then ran `ninja check-all` and from within stage2-bins/ but that failed: [1072/1526] cd

[PATCH] D62279: Use LTO capable linker

winksaville abandoned this revision. winksaville added a comment. Chris, I thought you had added libcxxabi in LLVM_ENABLE_RUNTIMES, but you hadn't so abandoning and trying again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62279/new/

[PATCH] D62279: Use LTO capable linker

winksaville created this revision. winksaville added a reviewer: beanz. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini, mgorny. Herald added a project: clang. In DistributionExample.cmake be sure we use a LTO capable linker, the easiest to choose is lld. Repository: