[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

2019-05-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361475: [clangd-vscode] Do not customize uri converters in vscode (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D62288?vs=200909&id=200913#toc Repository:

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

2019-05-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 200909. kadircet marked an inline comment as done. kadircet added a comment. - Delete unusued import Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62288/new/ https://reviews.llvm.org/D62288 Files: clang-too

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

2019-05-23 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, this improves the paths produced for generated files inside `bazel-genfiles`, we now point to the `/my/project/bazel-genfiles/path/to/some.proto.h` instead of `/path/to/ba

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

2019-05-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Clangd is already resolving symlinks on the server side, therefore there is no more need to handle it in client side. This was