[PATCH] D62298: [CodeComplete] Filter override completions by function name

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361623: [CodeComplete] Filter override completions by function name (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62298?vs=201168=201178#toc Repository:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201168. ilya-biryukov added a comment. - Update a comment in the test - Reformat the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201167. ilya-biryukov added a comment. - Remove redundant test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201164. ilya-biryukov added a comment. - Do not add an extra 'override' on optional chunks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); kadircet wrote: > ilya-biryukov wrote:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201161. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Add whitespace outside printOverrideString Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201157. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/test/CodeCompletion/overrides.cpp:14 void vfunc(bool param) override; - void + vfo }; kadircet wrote: > nit: I suppose it should be `vfu`?(same thing for the comments below starting > with `Runs

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); ilya-biryukov wrote: > kadircet wrote: > >

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); kadircet wrote: > do we expect anything

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. In D62298#1515399 , @kadircet wrote: > LGTM > > Have one question though, does it improve behavior in vscode? Since label > seems to be the same, it will most definitely improve clangd's ranking but > vscode ignores it

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Have one question though, does it improve behavior in vscode? Since label seems to be the same, it will most definitely improve clangd's ranking but vscode ignores it anyway.

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. After landing this, will try to add new presentation options for completion items here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. I think that's a good step forward, although not yet ideal. The typed chunk now contains everything starting function name and ending with `override`, so one gets both nice prefix match scores when typing a function

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 201000. ilya-biryukov added a comment. Herald added subscribers: arphaman, jkorous. - Make first letter of the helper function lowercase - New model: everything before name is a text chunk, everything after it is typed chunk - Test the filter text

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. Summarizing the offline discussion, the final results we want in the long run is a completion item of the form: - Displayed to the user: `override foo(int a, int b)` - Inserted into the editor: `return_type foo(int a, int b) override` - Filtered by `override foo`

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3166 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) + Result.AddChunk(CodeCompletionString::CK_HorizontalSpace);

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3154 +/// The result contains only 'typed text' and 'text' chunks. +static void PrintOverrideString(const CodeCompletionString , +CodeCompletionBuilder ) {

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov updated this revision to Diff 200927. ilya-biryukov added a comment. - Simplify negative tests a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 Files:

[PATCH] D62298: [CodeComplete] Filter override completions by function name

ilya-biryukov added a comment. Sorry for so many changes, this is ready for review now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62298/new/ https://reviews.llvm.org/D62298 ___ cfe-commits mailing