[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

This revision was automatically updated to reflect the committed changes. Closed by commit rL362266: Clarify when fix-it hints on warnings are appropriate (authored by aaronpuchert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANG

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://reviews.llvm.org/D62470 ___

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

rsmith added a comment. Thanks, looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://reviews.llvm.org/D62470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert updated this revision to Diff 201597. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Put the important part first, and the rest in a separate sentence. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://rev

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert marked 3 inline comments as done. aaronpuchert added inline comments. Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in ca

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaron.ballman added inline comments. Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in cases + of counter-intuitive precedence, when t

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert marked 2 inline comments as done. aaronpuchert added inline comments. Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in ca

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaron.ballman added a comment. Thank you for working on this! Comment at: docs/InternalsManual.rst:426-428 +* Fix-it hints on a warning should only clarify the meaning of the existing + code, not change it. Examples for such hints are added parentheses in cases + of counter-i

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert added a comment. Feel free to suggest better wording, I'm not a native speaker. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://reviews.llvm.org/D62470 ___ cfe-commits mailing list cfe-c

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert created this revision. aaronpuchert added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is not a change in the rules, it's meant as a clarification about warnings. Since the recovery from warnings is a no-op, the fix-it h