[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

2019-06-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

2019-06-03 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In D62616#1522284 , @gribozavr wrote: > I totally agree about the space before the opening curly, but the space > before the opening paren is a matter of style. Certainly it does match LLVM > style better, but it does not

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

2019-05-29 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I totally agree about the space before the opening curly, but the space before the opening paren is a matter of style. Certainly it does match LLVM style better, but it does not match

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

2019-05-29 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {` This slightly improves the final output. Should not affect clients