This revision was automatically updated to reflect the committed changes.
Closed by commit rL363748: Show note for -Wmissing-prototypes for functions
with parameters (authored by aaronpuchert, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:13335
+? FixItHint::CreateInsertion(FTL.getRParenLoc(),
"void")
+: FixItHint{});
}
aaronpuchert wrote:
> aaron.ballman wrote:
> > In t
aaronpuchert added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:13335
+? FixItHint::CreateInsertion(FTL.getRParenLoc(),
"void")
+: FixItHint{});
}
aaron.ballman wrote:
> In this case, we could probab
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/Sema/SemaDecl.cpp:13335
+? FixItHint::CreateInsertion(FTL.getRParenLoc(),
"void")
+: FixI
aaronpuchert updated this revision to Diff 204171.
aaronpuchert added a comment.
Add checks that we don't emit the fix-it when we shouldn't.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62750/new/
https://reviews.llvm.org/D62750
Files:
include/clang/Basic/Dia
aaronpuchert created this revision.
aaronpuchert added reviewers: aaron.ballman, rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
There was a search for non-prototype declarations for the function, but
we only showed the results for zero-parameter functions. Now we sh
