[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

This revision was automatically updated to reflect the committed changes. Closed by commit rL364389: [clangd] Enable extraction of system includes from custom toolchains (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 206231. kadircet marked 9 inline comments as done. kadircet added a comment. - Rename SystemIncludeExtractor to QueryDriverDatabase - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ h

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:345 CompileCommandsDir); +if (!ClangdServerOpts.QueryDriverGlobs.empty()) + BaseCDB = get

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm.org/D62804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. In D62804#1538202 , @ilya-biryukov wrote: > In D62804#1538155 , @kadircet wrote: > > > For example a gcc cross compiling to arm comes with its own system includes > > and has some mechani

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 204243. kadircet added a comment. - Fix off-by-one bug and improve lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm.org/D62804 Files: clang-tools-extra/clangd/CMakeList

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

ilya-biryukov added a comment. In D62804#1538155 , @kadircet wrote: > For example a gcc cross compiling to arm comes with its own system includes > and has some mechanisms to discover that implicitly, without requiring any > "-I" flags. > Hence when use

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. In D62804#1533710 , @ilya-biryukov wrote: > Could you give more context on what the custom toolchains are? > One feasible alternative is to move this detection to clang's driver (where > the rest of include path detection lives

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet updated this revision to Diff 204066. kadircet marked 27 inline comments as done. kadircet added a comment. Herald added a subscriber: mgorny. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

ilya-biryukov added a comment. Could you give more context on what the custom toolchains are? One feasible alternative is to move this detection to clang's driver (where the rest of include path detection lives), why won't that work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

sammccall added a comment. Implementation looks good. I can't see a better way to solve this problem, it's just a bit unfortunate to have a sophisticated solution but not be able to turn it on by default. I think naming is important here: it's a fairly complicated feature that (I suppose) rela

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Some custom toolchains come with their own header files and compiler drivers. Those compiler drivers implicitly kn