[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

2019-06-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 203072. nridge added a comment. Fill in BackgroundIndex and Dex implementations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62839/new/ https://reviews.llvm.org/D62839 Files:

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

2019-06-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D62839#1528597 , @nridge wrote: > For relations, should we include a copy in both the file containing the > definition of the subject, and (if different) the file containing the > definition of the object? The point of

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

2019-06-03 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. This isn't quite ready for a thorough review, but I have a question for now: in `BackgroundIndex::update`, there is a step where we partition symbols and references into files. For relations, should we include a copy in both the file containing the definition of the

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

2019-06-03 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Remaining work: - BackgroundIndex implementation - Dex implementation Repository: rG LLVM Github Monorepo