[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. Fixed in D63454 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. In D63009#1545152 , @gtbercea wrote: > In D63009#1544984 , @ABataev wrote: > > > In D63009#1544900 , @gtbercea > > wrote: > > > > > In D63009#154475

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. In D63009#1544984 , @ABataev wrote: > In D63009#1544900 , @gtbercea wrote: > > > In D63009#1544758 , @Hahnfeld > > wrote: > > > > > Am I correct th

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. In D63009#1544900 , @gtbercea wrote: > In D63009#1544758 , @Hahnfeld wrote: > > > Am I correct that the second to last revision ("- Fix tests.") removed all > > checks for the actual `devic

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. In D63009#1544758 , @Hahnfeld wrote: > Am I correct that the second to last revision ("- Fix tests.") removed all > checks for the actual `device_id` argument from the tests? From my point of > view that's not fixing but weakeni

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. In D63009#1544784 , @ABataev wrote: > The tests must check the device ID for target-based calls of the task alloc > function. Since device ID is now an expression I can only do this: i64 {{.*}}) Is this what you wanted? @AB

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. The tests must check the device ID for target-based calls of the task alloc function. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ http

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. In D63009#1544758 , @Hahnfeld wrote: > Am I correct that the second to last revision ("- Fix tests.") removed all > checks for the actual `device_id` argument from the tests? From my point of > view that's not fixing but weakenin

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

Hahnfeld added a comment. Am I correct that the second to last revision ("- Fix tests.") removed all checks for the actual `device_id` argument from the tests? From my point of view that's not fixing but weakening the tests! Can you explain why they needed "fixing"? If I had to guess this is b

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

This revision was automatically updated to reflect the committed changes. Closed by commit rL363451: [OpenMP] Add target task alloc function with device ID (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES S

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { AlexEichenber

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

AlexEichenberger added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > gtbercea wr

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > gtbercea wrote: > >

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > gtbercea wrote: > >

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > Can we use the same

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { ABataev wrote

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204763. gtbercea added a comment. - Fix function name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_codegen.cp

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1927 + case OMPRTL__kmpc_omp_target_task_alloc: { +// Build kmp_task_t *__kmpc_omp_task_alloc(ident_t *, kmp_int32 gtid, +// kmp_int32 flags, size_t sizeof_kmp_task_t, size_t sizeof_shareds, -

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 __

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204320. gtbercea added a comment. - Fix tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_codegen.cpp test

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204294. gtbercea added a comment. - Add device ID if available. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_c

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204141. gtbercea added a comment. - Add tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_depend_codegen.cpp test

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea updated this revision to Diff 204139. gtbercea added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. - Add temporary implementation. Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.or

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. This patches does not add any functionality. I thought, it was published by an accident. The patch should be abandoned or reworked to add a functional part of the code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://re

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

AlexEichenberger added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:610 + // size_t sizeof_shareds, kmp_routine_entry_t *task_entry, + // size_t device_id); + OMPRTL__kmpc_omp_target_task_alloc, device_id is int64_t Comment a

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

Hahnfeld added a comment. As for D63010 , the new function isn't used anywhere (and hence cannot be tested). What's the advantage of splitting changes at such granularity? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. Add a new call to Clang to perform task allocation for the target. Repository: rC Clang https://reviews.llvm