rnk marked an inline comment as done.
rnk added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9809
+ // variable template specializations inline.
+ if (isa(VD) && VD->isConstexpr())
+return GVA_DiscardableODR;
rsmith wrote:
> It'd be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363191: [MS] Pretend constexpr variable template
specializations are inline (authored by rnk, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/ASTContext.cpp:9809
+ // variable template specializations inline.
+ if (isa(VD) && VD->isConstexpr())
+return GVA_Discardable
rnk created this revision.
rnk added a reviewer: rsmith.
Herald added a project: clang.
Fixes link errors with clang and the latest Visual C++ 14.21.27702
headers, which was reported as PR42027.
I chose to intentionally make these things linkonce_odr, i.e.
discardable, so that we don't emit defin
