This revision was automatically updated to reflect the committed changes.
Closed by commit rL364088: [clang-scan-deps] print the dependencies to stdout
(authored by arphaman, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63579/new/
https://reviews.llvm.org/D63579
___
cfe-commits mailing list
arphaman updated this revision to Diff 205938.
arphaman added a comment.
Use the shared stream as suggested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63579/new/
https://reviews.llvm.org/D63579
Files:
clang/include/clang/Frontend/Utils.h
clang/lib/Frontend/DependencyFile.cpp
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32
+class DependencyCollectorFactory {
+public:
aganea wrote:
> arphaman wrote:
> > aganea wrote:
> > > Do you envision future
aganea added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32
+class DependencyCollectorFactory {
+public:
arphaman wrote:
> aganea wrote:
> > Do you envision future uses for this factory?
> Most likely, yes.
>
> I don't want to
arphaman added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32
+class DependencyCollectorFactory {
+public:
aganea wrote:
> Do you envision future uses for this factory?
Most likely, yes.
I don't want to lock-in into creating the
arphaman updated this revision to Diff 205886.
arphaman marked 3 inline comments as done.
arphaman added a comment.
removed the lock
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63579/new/
https://reviews.llvm.org/D63579
Files:
clang/include/clang/Frontend/Utils.h
aganea added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32
+class DependencyCollectorFactory {
+public:
Do you envision future uses for this factory?
Comment at:
arphaman created this revision.
arphaman added reviewers: Bigcheese, aganea.
Herald added subscribers: tschuett, dexonsmith, jkorous.
Herald added a project: clang.
The gathered dependencies are now printed to the STDOUT instead of being
written to disk. The tool also doesn't need the dependency
