[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-10 Thread Matt Morehouse via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbef187c75090: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist`… (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-10 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-10 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk updated this revision to Diff 256556. tuktuk added a comment. I forgot to apply //clang-format// on //clang/lib/Driver/SanitizerArgs.cpp//, now it should be OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-10 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk updated this revision to Diff 256546. tuktuk added a comment. I was indeed able to run the test again after changing its name to //.cpp//, thank you for your help. I have restored XFAIL lines from the original //sanitizer_coverage_no_prune.cpp// that I should not have deleted. Now the

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-09 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse requested changes to this revision. morehouse added a comment. This revision now requires changes to proceed. In D63616#1961449 , @tuktuk wrote: > Am I missing an additional step for test integration, after adding the test > file? Just tried

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-09 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. Thanks again for the patch. Sorry about the delay in landing it; I'll work on it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:218 Opts.StackDepth = CGOpts.SanitizeCoverageStackDepth; - PM.add(createSanitizerCoverageModulePass(Opts)); + PM.add(createSanitizerCoverageModulePass(Opts,

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-04-04 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk updated this revision to Diff 255032. tuktuk added a comment. Thank you for your interest in this feature! It is unfortunate indeed that the patch was not merged when accepted, so here is an update that matches the current status of the code base. Dear reviewers, can you please make

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-03-31 Thread sakura via Phabricator via cfe-commits
eternalsakura added a comment. In D63616#1562824 , @tuktuk wrote: > Thanks for the reviews. Hi, @tuktuk. I want to use this function on the latest llvm, but now the code has been modified, this patch is no longer valid, can you take a look, thank you

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-03-31 Thread Xingwei Lin via Phabricator via cfe-commits
xwlin222 added a comment. Think so, and when can this feature be merge to the mainline? look forward it. In D63616#1809697 , @dende wrote: > This is a really useful feature for fuzzing bigger software projects and the > review was accepted. Any plans to

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2020-01-08 Thread Christian Hartlage via Phabricator via cfe-commits
dende added a comment. This is a really useful feature for fuzzing bigger software projects and the review was accepted. Any plans to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-28 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk added a comment. Thanks for the reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-28 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-28 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk updated this revision to Diff 207086. tuktuk edited the summary of this revision. tuktuk added a comment. I followed Matt Morehouse's advice: mainly, I adapted the test so that it uses libFuzzer's default SanitizerCoverage options instead of `trace-pc`, and I rewrote some parts of the

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-24 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added a comment. Thanks for the patch! Seems like a useful feature for targeted fuzzing. Comment at: clang/docs/SanitizerCoverage.rst:310 + +In most cases, the whitelist will list the folders or source files for which you want +instrumentation and allow all

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-21 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk updated this revision to Diff 206006. tuktuk added a comment. Herald added subscribers: Sanitizers, kubamracek, srhines. I followed Roman Lebedev's advice and adapted the `sanitizer_coverage_no_prune.cc` test to create a `sanitizer_coverage_whitelist_blacklist.cc` test under `make

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Test coverage missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

2019-06-20 Thread Yannis Juglaret via Phabricator via cfe-commits
tuktuk created this revision. tuktuk added reviewers: kcc, morehouse. tuktuk added projects: clang, Sanitizers. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: LLVM. This commit adds two command-line options to clang. These options let the user decide which