pcc added inline comments.
Comment at: compiler-rt/trunk/lib/hwasan/hwasan_checks.h:76
+#endif
+ return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag;
+}
xiangzhangllvm wrote:
> Hello @pcc I think here seems some problem, the ptr is user passing point,
>
xiangzhangllvm added inline comments.
Comment at: compiler-rt/trunk/lib/hwasan/hwasan_checks.h:76
+#endif
+ return *(u8 *)(ptr | (kShadowAlignment - 1)) == ptr_tag;
+}
Hello @pcc I think here seems some problem, the ptr is user passing point,
*(ptr + n) should
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365551: hwasan: Improve precision of checks using short
granule tags. (authored by pcc, committed by ).
Herald added a subscriber: delcypher.
Changed prior to commit:
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63908/new/
https://reviews.llvm.org/D63908
pcc updated this revision to Diff 208758.
pcc marked 3 inline comments as done.
pcc added a comment.
- Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63908/new/
https://reviews.llvm.org/D63908
Files:
pcc added inline comments.
Comment at: compiler-rt/lib/hwasan/hwasan_allocator.cpp:159
? (t ? t->GenerateRandomTag() : kFallbackAllocTag)
: 0;
+uptr tag_size = orig_size ? orig_size : 1;
eugenis wrote:
> When
eugenis added inline comments.
Comment at: compiler-rt/lib/hwasan/hwasan_allocator.cpp:159
? (t ? t->GenerateRandomTag() : kFallbackAllocTag)
: 0;
+uptr tag_size = orig_size ? orig_size : 1;
When
pcc updated this revision to Diff 207379.
pcc added a comment.
- Simplify tagAlloca
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63908/new/
https://reviews.llvm.org/D63908
Files:
clang/docs/HardwareAssistedAddressSanitizerDesign.rst
pcc created this revision.
pcc added a reviewer: eugenis.
Herald added subscribers: Sanitizers, cfe-commits, jfb, hiraditya, javed.absar,
kubamracek.
Herald added projects: clang, Sanitizers, LLVM.
A short granule is a granule of size between 1 and `TG-1` bytes. The size
of a short granule is
