[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365120: [clangd] Also cache failures while indexing (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 207484. kadircet marked 2 inline comments as done. kadircet added a comment. - Update fixme to mention error case in addition to the missing files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ http

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/index/Background.cpp:313 +// we don't even know what absolute path they should fall in. +if (HadErrors && !IGN.IsTU) + continue; kadircet wrote: > sammccall wrote: > > Maybe a

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:313 +// we don't even know what absolute path they should fall in. +if (HadErrors && !IGN.IsTU) + continue; sammccall wrote: > Maybe add a FIXME that we should

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 207316. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ https://reviews.llvm.org/D63986 Files: clang-tools-ex

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/index/Background.cpp:140 + +void storeSlabs(BackgroundIndexStorage *IndexStorage, PathRef Identifier, +Symb

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:161 CI.getDiagnostics().hasUncompilableErrorOccurred()) { llvm::errs() << "Skipping TU due to uncompilable errors\n"; +} else { sammccall wrote: > I'm p

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 207296. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ https://reviews.llvm.org/D63986 Files: clang-tools-ex

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Change looks sensible, just wondering if we should keep the main-file symbols/refs, and whether we can simplify/unify a bit. Comment at: clang-tools-extra/clangd/index/Background.cpp:359 } // Build and store new slabs for each updated file. -

[PATCH] D63986: [clangd] Also cache failures while indexing

2019-07-01 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd currently doesn't cache any indexing failures, which results in retrying those failed files even if their c