[PATCH] D64123: Add clang-llvm-rename tool.

ruiu updated this revision to Diff 208883. ruiu added a comment. - Add a comment as to how to build and run clang-llvm-rename tool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/ https://reviews.llvm.org/D64123 Files:

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu added a comment. I wasn't aware that clang-tidy had a such feature. readability-identifier-naming rule doesn't seem to work for this purpose out of the box. That being said, in hindsight, maybe I should have written this as a patch to clang-tidy instead of a new tool (which should have

[PATCH] D64123: Add clang-llvm-rename tool.

michaelplatings added a comment. Hi @ruiu, Can you comment on how this compares to clang-tidy? I had assumed that the readability-identifier-naming clang-tidy rule would largely do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu updated this revision to Diff 208116. ruiu added a comment. - updated a few special mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/ https://reviews.llvm.org/D64123 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu added a comment. In D64123#1568096 , @Eugene.Zelenko wrote: > There is clang-rename > > already. May be new functionality should be added there? clang-rename seems to

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu updated this revision to Diff 207937. ruiu added a comment. - removed a special rule for `E` - do not lowercase global variables whose name is all uppercase - OSec -> osec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/

[PATCH] D64123: Add clang-llvm-rename tool.

Eugene.Zelenko added a comment. There is clang-rename already. May be new functionality should be added there? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/

[PATCH] D64123: Add clang-llvm-rename tool.

ruiu created this revision. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. ruiu planned changes to this revision. Currently, this tool can rename variables in lld's source tree without breaking it, but it is very unlikely that it will work on any other LLVM