This revision was automatically updated to reflect the committed changes.
Closed by commit rL365123: [clangd] Make HadErrors part of background
indexs internal state (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
kadircet updated this revision to Diff 207986.
kadircet marked 6 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64147/new/
https://reviews.llvm.org/D64147
Files:
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Logic looks great, just naming/comment nits
Comment at: clang-tools-extra/clangd/index/Background.cpp:276
+const auto DigestIt =
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D64147
Files:
