[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

This revision was automatically updated to reflect the committed changes. Szelethus marked 5 inline comments as done. Closed by commit rL368771: [analyzer] Prune calls to functions with linear CFGs that return a non-zero… (authored by Szelethus, committed by ). Herald added a project: LLVM.

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sry, should have approved this ages ago >.< Comment at: clang/test/Analysis/uninit-vals.c:181 void testUseHalfPoint() { - struct Point p = getHalfPoint(); //

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 212801. Szelethus added a comment. Use `size() == 3` instead if `isLinear()`, add a related test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64232/new/ https://reviews.llvm.org/D64232 Files:

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 211744. Szelethus added a comment. - Be even more strict on the rule: mark the note as prunable even if the note message says `.*(loaded from '')`. This is okay, because `ReturnVisitor` will track the return value anyways, and if at least a single

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus added a comment. LLVM+Clang (A total of 207 reports changed) | with "track-conditions" set to true (bug length)

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1052 +// to return that every time. +if (N->getCFG().isLinear()) + WouldEventBeMeaningless = true; NoQ wrote: > This time i'd rather go

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 210330. Szelethus added a comment. Rebase on top master. Putting this on the bottom of the patch stack because this really deserves it's own analysis. (Side note, I completely messed up like ~40 hrs worth of analysis because I didn't check which branches

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:185 return true; return coin(); // tracking-note{{Returning value}} } NoQ wrote: > Szelethus wrote: > >

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1052 +// to return that every time. +if (N->getCFG().isLinear()) + WouldEventBeMeaningless = true; This time i'd rather go for "has exactly 3

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/uninit-vals.c:181 void testUseHalfPoint() { - struct Point p = getHalfPoint(); // expected-note{{Calling 'getHalfPoint'}} - //

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64232/new/ https://reviews.llvm.org/D64232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus updated this revision to Diff 208276. Szelethus added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64232/new/ https://reviews.llvm.org/D64232 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus marked 2 inline comments as done. Szelethus added a comment. In D64232#1570938 , @NoQ wrote: > I'm slightly worried that we're fighting the symptoms rather than the root > cause here: why were these values tracked that far in the first place

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

NoQ added a comment. I guess this makes sense. The results look good. I'm slightly worried that we're fighting the symptoms rather than the root cause here: why were these values tracked that far in the first place when we already have no interest in tracking them at the end of the function?

[PATCH] D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, dcoughlin, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. During the