[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365786: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP… (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1579154 , @NoQ wrote: > Ugh, i forced a lot of boilerplate on you. Hope it was worth it >.< > > Thank you!~ No problems, thanks for the review! Comment at:

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ugh, i forced a lot of boilerplate on you. Hope it was worth it >.< Thank you!~ Comment at: test/Analysis/cfg-openmp.cpp:3 + +// CHECK:void xxx(int argc) +// CHECK:

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev updated this revision to Diff 209042. ABataev added a comment. Improved code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64356/new/ https://reviews.llvm.org/D64356 Files: include/clang/AST/OpenMPClause.h include/clang/AST/StmtOpenMP.h

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. Yay, great! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64356/new/ https://reviews.llvm.org/D64356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev added a comment. In D64356#1576813 , @NoQ wrote: > Something like this: > > F9509417: photo_2019-07-09_12-21-46.jpg > > Like, you can construct a CFG for an arbitrary statement. CFG₁ is the CFG for > xxx() and

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. Something like this: F9509417: photo_2019-07-09_12-21-46.jpg Like, you can construct a CFG for an arbitrary statement. CFG₁ is the CFG for xxx() and CFG₂ is the CFG for the CapturedStmt (and its children). I'm trying to say that even if

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574981 , @NoQ wrote: > Ok, so i think i more or less understand where this is going and i like it! > My only concern about making sure that used-expressions don't appear in

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: lib/Analysis/CFG.cpp:4746-4750 + D->for_each_used_expr([this, ](Expr *E) { +assert(E && "Expected expression."); +if (CFGBlock *R = Visit(E)) + B = R; + }); NoQ

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a subscriber: rsmith. NoQ added a comment. Ok, so i think i more or less understand where this is going and i like it! My only concern about making sure that used-expressions don't appear in both CFGs; and, even then, it's likely that i'm wrong. +@rsmith just in case he has any

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:4746-4750 + D->for_each_used_expr([this, ](Expr *E) { +assert(E && "Expected expression."); +if (CFGBlock *R = Visit(E)) + B = R; + }); ABataev wrote: > NoQ wrote: > > Not sure, are these

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. In D64356#1574625 , @ABataev wrote: > That's strange. Maybe the patch applied incorrectly? Whoops, i needed to pull rC365334 . The patch has applied cleanly "with fuzz 2", which meant "oh there's

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574540 , @NoQ wrote: > I don't know much about OpenMP, but i guess i can help with the CFG a bit. Thanks a lot! > I strongly recommend adding a few direct tests for the CFG

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. I don't know much about OpenMP, but i guess i can help with the CFG a bit. I strongly recommend adding a few direct tests for the CFG so that to check that the order of statements and the overall topology of the CFG is as you intended. Currently those tests are routed

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev created this revision. ABataev added reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: jdoerfert, jfb, guansong, rnkovacs. Herald added a project: clang. Some OpenMP clauses rely on the values of the variables. If the variable