[PATCH] D64506: clang-cl: Remove -O0 option

This revision was automatically updated to reflect the committed changes. Closed by commit rL365724: clang-cl: Remove -O0 option (authored by nico, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D64506?vs=209092&id=209111#toc Repository:

[PATCH] D64506: clang-cl: Remove -O0 option

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64506/new/ https://reviews.llvm.org/D64506 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D64506: clang-cl: Remove -O0 option

thakis updated this revision to Diff 209092. thakis added a comment. Herald added subscribers: llvm-commits, kubamracek. Herald added a project: LLVM. update tests (not yet executed, don't have a win machine today) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64506/new/ https://review

[PATCH] D64506: clang-cl: Remove -O0 option

thakis added a comment. In D64506#1579251 , @rnk wrote: > Does `clang-cl -O0` without a `/` still work, though? It's used: > > $ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/ > ../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc:// RUN

[PATCH] D64506: clang-cl: Remove -O0 option

rnk added a comment. Does `clang-cl -O0` without a `/` still work, though? It's used: $ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/ ../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t ../compiler-rt/test/asan/TestCases/Windows/allocators_

[PATCH] D64506: clang-cl: Remove -O0 option

thakis added a comment. I did check that we now warn, like you had requested: $ out/gn/bin/clang-cl test.cc /O0 /c clang: warning: argument unused during compilation: '/O0' [-Wunused-command-line-argument] Adding a test for that felt weird though, so I didn't. CHANGES SINCE LAST ACTION

[PATCH] D64506: clang-cl: Remove -O0 option

thakis created this revision. thakis added a reviewer: rnk. cl.exe doesn't understand it; there's /Od instead. See also the review thread for r229575. https://reviews.llvm.org/D64506 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td ==