[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai abandoned this revision. smeenai added a comment. Abandoning in favor of D65839 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm.org/D64538

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

rnk added a comment. In D64538#1579632 , @smeenai wrote: > I'm not fully understanding this. If the .sh file was generated on Windows, > it'll contain backslashes in any arguments that are paths, right? Before this > change, those backslashes would have

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579610 , @rnk wrote: > In D64538#1579573 , @smeenai wrote: > > > In D64538#1579561 , @rnk wrote: > > > > > An extremely convenient

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

rnk added a comment. In D64538#1579573 , @smeenai wrote: > In D64538#1579561 , @rnk wrote: > > > An extremely convenient feature of the current escaping pattern is that it > > magically works for both the cmd

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579561 , @rnk wrote: > An extremely convenient feature of the current escaping pattern is that it > magically works for both the cmd shell and various bash implementations. You > can simply copy paste the commands and

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

rnk added a comment. An extremely convenient feature of the current escaping pattern is that it magically works for both the cmd shell and various bash implementations. You can simply copy paste the commands and run them. This matters, for example, for the .sh crash reproducer script. On

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a subscriber: phosek. smeenai added a comment. CC @phosek, since I believe you had issues writing tests referencing the installation directory in the past. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. In D64538#1579510 , @smeenai wrote: > Hmm, this only fixes `-###`. Looking into `-v` now. Ignore this – I was testing with a version without my change :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai added a comment. Hmm, this only fixes `-###`. Looking into `-v` now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm.org/D64538 ___ cfe-commits mailing list

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai created this revision. smeenai added reviewers: compnerd, hans, mstorsjo, rnk, thakis, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. Escaping backslashes results in unnatural looking output, and the actual escapes are mostly unnecessary. We were also not