[PATCH] D64564: Loop pragma parsing. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368976: [clang] Loop pragma parsing. NFC. (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. Thanks, and will fix your suggestions before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur accepted this revision. Meinersbur added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParsePragma.cpp:1010 + StringRef Str = PragmaName.getIdentifierInfo()->getName(); + std::string ClangLoopStr = (Twine("clang loop ")

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer updated this revision to Diff 215162. SjoerdMeijer added a comment. thanks for the suggestions; comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/Pa

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. Sorry, should have done my std::string, StringRef, and Twine homework a lot better! Thanks for your help and suggestions, will fix this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 __

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1010 + StringRef Str = PragmaName.getIdentifierInfo()->getName(); + StringRef ClangLoopStr = "clang loop " + Str.str(); + Str = llvm::StringSwitch(Str) [serious] Use-after-free here

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. this is not important at all, but might be nice clean up, so friendly ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer updated this revision to Diff 212878. SjoerdMeijer added a comment. Fixed the string problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/ParsePragma.cpp ===

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: lib/Parse/ParsePragma.cpp:1011 + Str = llvm::StringSwitch(Str) + .Case("loop", "clang loop " + Str.str()) + .Case("unroll_and_jam", Str) Me

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: lib/Parse/ParsePragma.cpp:1011 + Str = llvm::StringSwitch(Str) + .Case("loop", "clang loop " + Str.str()) + .Ca

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 ___ cfe-commits mailing list cfe-c

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer added a comment. oh no, the diff got messed up here. I.e. Phab shows 2 modified files, because the first patch set was created in a monorepo, and the 2nd patch set in a another and separate clang repo. Just for clarity, file `lib/Parse/ParsePragma.cpp` is the latest with the feedb

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer updated this revision to Diff 209299. SjoerdMeijer marked an inline comment as not done. SjoerdMeijer added a comment. thanks for taking a look and the suggestions! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64564/new/ https://reviews.llvm.org/D64564 Files: lib/Parse/

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1009 static std::string PragmaLoopHintString(Token PragmaName, Token Option) { - std::string PragmaString; - if (PragmaName.getIdentifierInfo()->getName() == "loop") { -PragmaString = "clang loop

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1015 + .Default(""); + assert(Str.size() && "Unexpected pragma name"); + return Str; I guess this does behave slightly d

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: samparker, dmgreen, Meinersbur. Yesterday I was a bit distracted by loop pragma parsing (D64471 ), but still am a bit today too (this patch). https://reviews.llvm.org/D64564 Files: clang/lib/Pa