[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added a comment. Submitted as r366267. Thanks! Comment at: clang/lib/Format/TokenAnnotator.cpp:389 bool isCpp11AttributeSpecifier(const FormatToken ) { if (!Style.isCpp() || !Tok.startsSequence(tok::l_square, tok::l_square)) return false;

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL366267: [clang-format] Dont detect call to ObjC class method as C++11 attribute… (authored by benhamilton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 added a comment. I don't think I have commit access. Could someone land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 ___ cfe-commits

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 updated this revision to Diff 209777. rkgibson2 added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7030-7032 + // Make sure that we do not mistake a call to the Objective-C method named + // "class" inside an array literal as attributes. + verifyFormat("@[ [NSArray class] ];");

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 updated this revision to Diff 209504. rkgibson2 added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

aaron.ballman added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:389 bool isCpp11AttributeSpecifier(const FormatToken ) { if (!Style.isCpp() || !Tok.startsSequence(tok::l_square, tok::l_square)) return false; Clang has a

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 updated this revision to Diff 209496. rkgibson2 added a comment. Respond to comments and change detection method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/ https://reviews.llvm.org/D64632 Files:

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 marked an inline comment as done. rkgibson2 added a comment. In D64632#1582793 , @benhamilton wrote: > Thanks for the fix. One question: how does the real Clang parser deal with > this case? Is it something that's actually ambiguous in the

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:400-413 while (AttrTok && !AttrTok->startsSequence(tok::r_square, tok::r_square)) { // ObjC message send. We assume nobody will use : in a C++11 attribute // specifier

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

benhamilton added a comment. Thanks for the fix. One question: how does the real Clang parser deal with this case? Is it something that's actually ambiguous in the ObjC++ grammar, I wonder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64632/new/

[PATCH] D64632: [clang-format] Don't detect call to ObjC class method as C++11 attribute specifier

rkgibson2 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64632 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: