[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a comment. Problem should be fixed now (r367013). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

RKSimon added a comment. @balazske This is causing buildbot failures - revert? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 ___ cfe-commits mailing list

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367006: [CrossTU] Fix plist macro expansion if macro in other file. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske updated this revision to Diff 211689. balazske added a comment. Herald added a subscriber: mgorny. Added clangFrontend to CMakeLists.txt. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638 Files:

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a comment. The Frontend is needed because "ASTUnit.h" is added now into PlistDiagnostics.cpp. The `ASTUnit` object is used to pass information out from `getImportedFromSourceLocation`. The StaticAnalyzerCore library uses CrossTU library, and CrossTU uses Frontend, so I think it

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

NoQ added a comment. The preprocessor is defined in `Lex`, so i guess i'm curious about a more precise description of what's impossible to do without `Frontend`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a comment. Maybe CrossTU should not use the Frontend library? (Now the StaticAnalyzerCore is using CrossTU and CrossTU is using Frontend, in this way StaticAnalyzerCore could use Frontend too.) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a comment. It is possible to use the `Preprocessor` instead of `ASTUnit` in `getImportedFromSourceLocation`. But this will contain less useful (even if currently not used) information. The test extension in D65064 is not possible to do if not

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

martong added a subscriber: NoQ. martong added a comment. In D64638#1593382 , @ilya-biryukov wrote: > `StaticAnalyzer/Core` does not depend on `clangFrontend` now, you can see > this by looking at `lib/StaticAnalyzer/Core/CMakeLists.txt`: > >

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

ilya-biryukov added a comment. `StaticAnalyzer/Core` does not depend on `clangFrontend` now, you can see this by looking at `lib/StaticAnalyzer/Core/CMakeLists.txt`: add_clang_library(clangStaticAnalyzerCore ... LINK_LIBS clangAST clangASTMatchers clangAnalysis

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske added a reviewer: ilya-biryukov. balazske added a subscriber: ilya-biryukov. balazske added a comment. @ilya-biryukov Please check if it is acceptable to use `ASTUnit` in PlistDiagnostic.cpp. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64638/new/ https://reviews.llvm.org/D64638

[PATCH] D64638: [CrossTU] Fix plist macro expansion if macro in other file.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a project: clang. When cross TU analysis is used it is possible that a macro expansion is generated for a macro that is defined (and used) in other than the main translation unit. To