[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

This revision was automatically updated to reflect the committed changes. Closed by commit rL373862: [Sema] Avoids an assertion failure when an invalid conversion declaration is… (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

Mordante added a comment. Thanks for the review. Can you commit the patch since I don't have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

Mordante updated this revision to Diff 218213. Mordante added a comment. Addresses the review remarks: - Moved the unit test to SemaCXX (also use the PR as name of the file) - Change the unit test to use `-verify` instead of `FileCheck` CHANGES SINCE LAST ACTION

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith added inline comments. Comment at: clang/test/Sema/conversion_function_to_function.cpp:1 +// RUN: not %clang_cc1 -fsyntax-only -std=c++14 %s 2>&1 | FileCheck %s + Use `%clang_cc1 -verify` instead of `not %clang_cc1 | FileCheck` Comment

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith added inline comments. Comment at: clang/test/Sema/conversion_function_to_function.cpp:1 +// RUN: not %clang_cc1 -fsyntax-only -std=c++14 %s 2>&1 | FileCheck %s + rsmith wrote: > Use `%clang_cc1 -verify` instead of `not %clang_cc1 | FileCheck` This test