Mordante added a comment.
@rsmith I now have commit access so I can commit the patch. Any suggestions
regarding the previous remark?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64874/new/
https://reviews.llvm.org/D64874
___
cfe-commits
Mordante updated this revision to Diff 224753.
Mordante added a comment.
Removed the language version test.
I also added `clang/test/CXX/conv/conv.fctptr/template-noreturn.cpp` to show
this is not enough to allow `noreturn` to all language versions, so this file
should not be committed.
Do
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, though I'd like to see this generalized to handle noreturn too.
Comment at: clang/lib/Sema/SemaTemplate.cpp:6997
+ QualType ResultTy;
+ if
Mordante updated this revision to Diff 218215.
Mordante added a comment.
Addresses the review remarks:
- resultTy -> ResultTy
- Move all unit tests in one file
- Change the unit test to use `-verify` instead of `FileCheck`
- Use PR40024 instead of link to Bugzilla
CHANGES SINCE LAST ACTION
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:6996
+ // a noexcept function can be converted to a noexcept(false) function.
+ QualType resultTy;
+ if (getLangOpts().CPlusPlus17 &&
Please capitalize local variable names
