[PATCH] D64958: [clang-doc] Fix link generation

This revision was automatically updated to reflect the committed changes. Closed by commit rL367958: [clang-doc] Fix link generation (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213498. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Fix comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files: clang-tools-extra/clang-doc/BitcodeRe

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett accepted this revision. juliehockett added a comment. LGTM with a comment correction Comment at: clang-tools-extra/clang-doc/Representation.h:117 Reference(llvm::StringRef Name) : Name(Name) {} - Reference(llvm::StringRef Name, StringRef Path) : Name(Name), Pat

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 213128. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64958/new/ https://reviews.llvm.org/D64958 Files: clang-tools-extra/clang-doc/BitcodeRea

[PATCH] D64958: [clang-doc] Fix link generation

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. The code looks fine to me but I don't understand the global details of this. Hopefully Julie can still review things from there but if not we don't get timely reviews then we can s

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran updated this revision to Diff 211979. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Change attribute used to check special case of global namespace; IsPathValid changed to IsInGlobalNamespace. This attribute is true when its first parent is

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran added a comment. In D64958#1601228 , @juliehockett wrote: > Under what circumstances, exactly, is the path not set where you would need > to create a link despite that? Is it only in the global namespace case? If > so, could you special-

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:137 +// saved (possibly unresolved) + bool IsPathValid = false; // Indicates if a value has been assigned to Path, +

[PATCH] D64958: [clang-doc] Fix link generation

juliehockett added a comment. Under what circumstances, exactly, is the path not set where you would need to create a link despite that? Is it only in the global namespace case? If so, could you special-case that and ignore other empty paths? Comment at: clang-tools-extra/cla

[PATCH] D64958: [clang-doc] Fix link generation

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Before making a link to a reference it is required to check that the reference has a path (eg. primitives won't have paths). This was