This revision was automatically updated to reflect the committed changes.
Closed by commit rL366719: Adds support for formatting NS_CLOSED_ENUM and
CF_CLOSED_ENUM alongside NS_ENUM… (authored by benhamilton, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Ch
heijink updated this revision to Diff 211137.
heijink added a comment.
Fixed formatting of Format.cpp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65012/new/
https://reviews.llvm.org/D65012
Files:
clang/lib/Format/Format.cpp
clang/lib/Format
heijink updated this revision to Diff 211135.
heijink added a comment.
Adds NS_CLOSED_ENUM to the keywords that cause LLVM to detect Objective-C.
Changed NSInteger to int in the unit tests, because NSInteger also signals
Objective-C.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
benhamilton added a comment.
Oh, I forgot there's one more place you should touch — the Objective-C style
guesser for headers will need to be updated to understand that `NS_CLOSED_ENUM`
indicates Objective-C:
https://reviews.llvm.org/source/llvm-github/browse/master/clang/lib/Format/Format.cpp$
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65012/new/
https://reviews.llvm.org/D65012
