[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-04 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367794: [Driver] Support for disabling sanitizer runtime linking (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 213267. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolCh

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 213237. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/sanit

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 213235. phosek added a comment. One more change, I went with `-fsanitize-runtime` and `-fno-sanitize-runtime` in the end which seems like the best fit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files:

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 213233. phosek added a comment. I've decided to go with the original `-f[no-]sanitize-link-deps`: `-fsanitize-minimal-runtime` is also a cc1 flag which affects codegen, `-fshared-libsan` and `-fstatic-libsan` are orthogonal, e.g. it's possible to have minima

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D65029#1613315 , @phosek wrote: > I've updated the change and renamed the flag to `-fsanitize-no-runtime` > although I'm not sure if it's necessarily better. I was thinking that ideal > interface might be `-fsanitize-runtime=(

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-08-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 213170. phosek edited the summary of this revision. phosek added a comment. Herald added a subscriber: cryptoad. I've updated the change and renamed the flag to `-fsanitize-no-runtime` although I'm not sure if it's necessarily better. I was thinking that ideal

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-07-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D65029#1594437 , @pcc wrote: > It's also worth asking whether `-nodefaultlibs` would work for this use case > as @filcab suggested on D64547 . It wouldn't, `-nodefaultlibs` (same as `-nostdlib`

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-07-19 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added subscribers: filcab, pcc. pcc added a comment. It's also worth asking whether `-nodefaultlibs` would work for this use case as @filcab suggested on D64547 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-07-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. There is an existing option `-fsanitize-minimal-runtime`, will `-fsanitize-no-runtime` be a name providing more consistency? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-07-19 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 ___ cfe-comm

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

2019-07-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: vitalybuka, morehouse, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change introduces a pair of -fsanitize-link-deps and -fno-sanitize-link-deps flags which can be used to control linking of sanitizer runtime