[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL367010: [clang] Add isDirectlyDerivedFrom AST matcher. (authored by AntonBikineev, committed by ). Herald added a project:

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211513. AntonBikineev marked an inline comment as not done. AntonBikineev added a comment. Missed that, thanks for the point! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Fil

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) AntonBikineev wrote: > aaron.ballman wrote:

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211508. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Thanks for the comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files: clang/do

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) aaron.ballman wrote: > I don't think this a

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2672 + BaseName, 1) { + assert(!BaseName.empty()); + return isDirectlyDerivedFrom(hasName(BaseName)) I don't think this assertion is reasonable

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek added a comment. So, I did like the more exhaustive doc, I thought you'd move it to the code so it also shows up in the generated doc page :) (sorry for not being clearer here) Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2637 internal::Match

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev added a comment. Manuel, would you mind taking another look at the change please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 ___ cfe-commits mailing list cf

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211261. AntonBikineev added a comment. Thanks for the note, updated the diff with autogenerated LibASTMatcherReference.html. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Fil

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek requested changes to this revision. klimek added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/LibASTMatchersReference.html:5277 +MatcherCXXRecordDecl>isDirectlyDe

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev updated this revision to Diff 211148. AntonBikineev added a comment. Manuel, I left some cases which deviated from the isDerivedFrom matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65092/new/ https://reviews.llvm.org/D65092 Files: clang/do

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

klimek added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2637 internal::Matcher, Base) { - return Finder->classIsDerivedFrom(&Node, Base, Builder); + return Finder->classIsDerivedFrom(&Node, Base, Builder, false); } ---

[PATCH] D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.

AntonBikineev created this revision. AntonBikineev added a reviewer: rsmith. AntonBikineev added a project: clang. This patch adds isDirectlyDerivedFrom AST-matcher which is similar to isDerivedFrom but only matches against direct base classes. Repository: rC Clang https://reviews.llvm.org/D