[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis abandoned this revision. thakis added a comment. We're going with D65233 instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs());

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs());

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nathanchance added a comment. I tested this patch on top of r366728 and saw no regressions in my set of kernel builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3564 +ArgStringList DummyArgs; +CollectArgsForIntegratedAssembler(C, Args, DummyArgs, D, + TC.useIntegratedAs()); I think it would be better

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > nickdesaulniers wrote: >

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) thakis wrote: > (This just wraps all the

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args))

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2051 + // Claim flags for the integrated assembler only if it's being used. + if (IsIntegratedAs) { +if (UseRelaxAll(C, Args)) (This

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis added a comment. Note to self: Check https://github.com/ClangBuiltLinux/linux/issues/598 before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65108/new/ https://reviews.llvm.org/D65108 ___ cfe-commits mailing list

[PATCH] D65108: Reland "driver: Don't warn about assembler flags being unused when not assembling"

thakis created this revision. thakis added a reviewer: rnk. This relands r365703 (and r365714), originally reviewed at https://reviews.llvm.org/D64527. The problem with the old approach was that clang would now warn about -Wa flags that the integrated assembler didn't understand even when