[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ abandoned this revision. NoQ added a comment. Merged into D64274 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 ___ cfe-commits mailing list

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 214441. NoQ added a comment. - Fix checker names for consumers that display them (eg., clang-tidy). Add a test. - Change bug descriptions: "Call to virtual function during construction or destruction" -> "Pure virtual method call" | "Unexpected loss of virtual

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

a_sidorin accepted this revision. a_sidorin added a comment. Hi Artem, The patch looks good to me. I prefer a fully qualified name, however, but it is a matter of taste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

Charusso accepted this revision. Charusso added a comment. When I started programming I read that the programming is British English, but LLVM project has more 'behavior' than 'behaviour', so as being democratic it should be fine. CHANGES SINCE LAST ACTION

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 211587. NoQ added a comment. One more thing: explain the consequences of the bug, so that it was obvious what the problem is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 Files:

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 ___ cfe-commits mailing list

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 211399. NoQ added a comment. - Hmm, also i'd rather say "method" than "function". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/ https://reviews.llvm.org/D65180 Files: clang/lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 211397. NoQ added a comment. - Print only class name::method name instead of a fully qualified name, because fully qualified names may get pretty long. - Remove more dead code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65180/new/

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D64274: