This revision was automatically updated to reflect the committed changes.
Closed by commit rL368694: [analyzer][NFC] Refactoring BugReporter.cpp P2.:
Clean up the construction of… (authored by Szelethus, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Szelethus updated this revision to Diff 212806.
Szelethus marked 2 inline comments as done.
Szelethus added a comment.
clang-format, rephrase the comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65379/new/
https://reviews.llvm.org/D65379
Files:
xazax.hun accepted this revision.
xazax.hun added a comment.
Looks good, some nits inline. I agree with Artem, we should consider omitting
the trimming and document how to get something similar if desired for debugging.
Just a random idea: maybe the original purpose of the trimming was to be
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
If only somebody could explain to me why do even need trimming in the first
place :/
I was only keeping it around for easier exploded graph dumps reading, but these
days we can trivially replace
